Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog action #434

Merged
merged 7 commits into from
Jul 20, 2021
Merged

Conversation

vhirtham
Copy link
Collaborator

@vhirtham vhirtham commented Jul 19, 2021

Changes

Disables the changelog action if the pull request is marked as "draft" and/or not targetting our master branch.

@vhirtham vhirtham marked this pull request as draft July 19, 2021 09:36
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #434 (7689b98) into master (699e4e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          87       87           
  Lines        5411     5411           
=======================================
  Hits         5263     5263           
  Misses        148      148           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699e4e2...7689b98. Read the comment docs.

@vhirtham vhirtham marked this pull request as ready for review July 19, 2021 09:41
@vhirtham vhirtham marked this pull request as draft July 19, 2021 09:45
@vhirtham vhirtham marked this pull request as ready for review July 19, 2021 09:51
@vhirtham vhirtham marked this pull request as draft July 19, 2021 09:52
@vhirtham vhirtham marked this pull request as ready for review July 19, 2021 09:54
@vhirtham vhirtham requested review from CagtayFabry and marscher July 19, 2021 09:55
Copy link
Member

@CagtayFabry CagtayFabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 💯 👍

@vhirtham vhirtham merged commit 08240b4 into BAMWelDX:master Jul 20, 2021
@vhirtham vhirtham deleted the update_changelog_action branch July 20, 2021 05:43
@CagtayFabry
Copy link
Member

wondering why it failed here though 🤔

@vhirtham
Copy link
Collaborator Author

There are multiple runs of this action listed. The first one failed because of the missing tag. After I added the tag, the action was restarted and skipped correctly. Since there is no new commit in conjunction with the relabeling, it looks a bit confusing because the failed run is still tied to the last commit, even though it does not represent the final outcome of the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants