Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wx_shape validator optional syntax #571

Merged
merged 9 commits into from
Sep 30, 2021

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Sep 29, 2021

Changes

see #184

Related Issues

Closes #184

Checks

  • updated CHANGELOG.rst
  • updated tests
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@CagtayFabry CagtayFabry added ASDF everything ASDF related (python + schemas) validation custom ASDF validators labels Sep 29, 2021
@CagtayFabry CagtayFabry added this to the 0.5.0 milestone Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #571 (0fce9ba) into master (02ff5a4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0fce9ba differs from pull request most recent head b2c167e. Consider uploading reports for the commit b2c167e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   94.87%   94.86%   -0.02%     
==========================================
  Files          93       93              
  Lines        5734     5742       +8     
==========================================
+ Hits         5440     5447       +7     
- Misses        294      295       +1     
Impacted Files Coverage Δ
weldx/asdf/util.py 86.52% <100.00%> (+0.07%) ⬆️
weldx/asdf/validators.py 98.73% <100.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ff5a4...b2c167e. Read the comment docs.

@CagtayFabry
Copy link
Member Author

I have added another way to indicate a optional shape requirement by enclosing the list in braces for instances where wx_shape is defined directly at the property

wx_shape: ([1,2,a])

@CagtayFabry CagtayFabry marked this pull request as ready for review September 29, 2021 13:51
@CagtayFabry CagtayFabry merged commit 1a5f8bf into BAMWelDX:master Sep 30, 2021
@CagtayFabry CagtayFabry deleted the shape_validator_optional branch September 30, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) validation custom ASDF validators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redefine "optional" syntax for wx_shape validation
2 participants