-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry enhancements #583
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 94.83% 94.67% -0.16%
==========================================
Files 93 93
Lines 5745 5768 +23
==========================================
+ Hits 5448 5461 +13
- Misses 297 307 +10
Continue to review full report at Codecov.
|
Co-authored-by: Cagtay Fabry <43667554+CagtayFabry@users.noreply.github.com>
Had a really annoying circular dependency in the docs only. It's gone now, but I might have overdone it at someplace. So if you see any unnecessary changes to the imports, let me know. Most of the uncovered lines are plot-related and will be covered once the new tutorials go online. So I think there is no need for additional testing. However, I will add a short and simple test case for the groove support, just to have that covered by the basic tests. |
imports look better now I guess (removing top level imports) 👍 did you do anything specific to fix this error? https://github.com/BAMWelDX/weldx/pull/583/checks?check_run_id=3827087537#step:10:178 |
Didn't try it so far, but busting those warnings "the right way" is extremely time-consuming. Try a fix and wait 5 minutes to see if it worked. If we want to get a warning-free build, I can just put it into the nitpick ignore. Is that okay? |
it's probably a good use for the nitpick ignore 👍 |
Changes
Apply some small enhancements to the
Geometry
class. Most of them help to improve the readability/understandability of the new tutorials.Geometry
from a profile and extrusion length__init__
also accepts groove typesk3d
as backend option toplot
Move to separate PR / issue
Checks
update example/tutorial notebooksupdate manifest file