Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated code #620

Merged
merged 8 commits into from
Oct 29, 2021

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Oct 28, 2021

Changes

  • remove deprecations for 0.5

Checks

  • updated CHANGELOG.rst
  • update example/tutorial notebooks

@CagtayFabry CagtayFabry added the deprecation function or dependency deprecations label Oct 28, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Oct 28, 2021

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 59s ⏱️ -23s
1 923 tests ±0  1 923 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit f397f0f. ± Comparison against base commit 2f15492.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #620 (f397f0f) into master (2f15492) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   94.57%   94.62%   +0.04%     
==========================================
  Files          93       93              
  Lines        5954     5931      -23     
==========================================
- Hits         5631     5612      -19     
+ Misses        323      319       -4     
Impacted Files Coverage Δ
weldx/asdf/util.py 89.83% <ø> (+1.03%) ⬆️
weldx/visualization/k3d_impl.py 78.37% <ø> (ø)
weldx/welding/util.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f15492...f397f0f. Read the comment docs.

@CagtayFabry CagtayFabry requested a review from vhirtham October 29, 2021 07:14
@CagtayFabry CagtayFabry merged commit 05debf0 into BAMWelDX:master Oct 29, 2021
@CagtayFabry CagtayFabry deleted the remove_deprecated_code branch October 29, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation function or dependency deprecations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants