-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit] added clean notebook output hook #639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 93 93
Lines 6011 6011
=======================================
Hits 5680 5680
Misses 331 331 Continue to review full report at Codecov.
|
nice find, this would replace our check-notebooks job we should certainly try the side effects of the kernel info removal. |
I guess this would simply our CI pipeline a bit, since we need to set the correct environment (or just override the existing kernel metadata). I can open up a follow up PR with removed kernel metadata to see what happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks for the cleanup
looks like the python version doesn't get cleaned after all but still nice to have a good way to format
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Changes
Added clean notebook output hook. Tested locally, works like a charm.
There is an additional argument to remove kernel metadata (e.g. the constant switching of the Python version, depending on the devs local version). But this also removed the name of the env "weldx". So I'm not sure if this would break something. That's why I just disabled it.