Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wx_property_tag list #670

Merged
merged 4 commits into from
Dec 10, 2021
Merged

Conversation

CagtayFabry
Copy link
Member

Changes

  • The wx_property_tag validator now also accepts lists of different tags (or tag patterns).

Checks

  • updated CHANGELOG.rst
  • updated tests

@CagtayFabry CagtayFabry added ASDF everything ASDF related (python + schemas) validation custom ASDF validators labels Dec 9, 2021
@CagtayFabry CagtayFabry added this to the 0.6.0 milestone Dec 9, 2021
@CagtayFabry CagtayFabry requested a review from vhirtham December 9, 2021 16:32
@CagtayFabry CagtayFabry self-assigned this Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Unit Test Results

       1 files  ±0         1 suites  ±0   1m 42s ⏱️ -4s
1 949 tests ±0  1 949 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit c9141e4. ± Comparison against base commit 9cef0ce.

♻️ This comment has been updated with latest results.

@CagtayFabry CagtayFabry removed their assignment Dec 9, 2021
@CagtayFabry
Copy link
Member Author

feel free to merge and take over to the GenericSeries @vhirtham

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #670 (c9141e4) into master (9cef0ce) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   96.12%   96.10%   -0.02%     
==========================================
  Files          91       91              
  Lines        5903     5906       +3     
==========================================
+ Hits         5674     5676       +2     
- Misses        229      230       +1     
Impacted Files Coverage Δ
weldx/asdf/validators.py 98.08% <66.66%> (-0.63%) ⬇️
weldx/tags/debug/test_property_tag.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cef0ce...c9141e4. Read the comment docs.

CHANGELOG.rst Outdated Show resolved Hide resolved
Co-authored-by: vhirtham <volker.hirthammer@gmail.com>
@CagtayFabry CagtayFabry merged commit b48a534 into BAMWelDX:master Dec 10, 2021
@CagtayFabry CagtayFabry deleted the wx_property_tag_list branch December 10, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) validation custom ASDF validators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants