-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third tutorial: geometry #681
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 95.90% 96.07% +0.17%
==========================================
Files 92 92
Lines 6321 6325 +4
==========================================
+ Hits 6062 6077 +15
+ Misses 259 248 -11
Continue to review full report at Codecov.
|
Seems like I missed something but https://weldx--681.org.readthedocs.build/en/681/tutorials/01_03_geometry.html nice... have to adjust the text at those sections. |
@marscher @CagtayFabry There is currently an import warning in all tutorials. If somebody already knows the solution, please let me know. Otherwise I have to investigate. See first cell here: https://weldx--681.org.readthedocs.build/en/681/tutorials/01_03_geometry.html |
good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks (and reads) really nice 👍 🚀
Changes
Add the third tutorial. Original PR was automatically closed. All suggestions have been addressed. I also needed to fix some of our
pint
decorators and some related internals because there was a problem in the originally out commentedk3d
plots.path
option toWeldxFile.info
andWeldxFile.show_asdf_header
Checks
updated testsupdate manifest file