Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third tutorial: geometry #681

Merged
merged 33 commits into from
Jan 27, 2022
Merged

Conversation

vhirtham
Copy link
Collaborator

@vhirtham vhirtham commented Jan 18, 2022

Changes

Add the third tutorial. Original PR was automatically closed. All suggestions have been addressed. I also needed to fix some of our pint decorators and some related internals because there was a problem in the originally out commented k3d plots.

  • add path option to WeldxFile.info and WeldxFile.show_asdf_header

Checks

  • updated CHANGELOG.rst
  • updated tests
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@vhirtham vhirtham added documentation Improvements or additions to documentation geometry labels Jan 18, 2022
@vhirtham vhirtham self-assigned this Jan 18, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #681 (2f3154a) into master (6bbbd2a) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   95.90%   96.07%   +0.17%     
==========================================
  Files          92       92              
  Lines        6321     6325       +4     
==========================================
+ Hits         6062     6077      +15     
+ Misses        259      248      -11     
Impacted Files Coverage Δ
weldx/asdf/file.py 97.04% <100.00%> (+0.03%) ⬆️
weldx/geometry.py 98.62% <100.00%> (+1.12%) ⬆️
weldx/visualization/k3d_impl.py 79.12% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbbd2a...2f3154a. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 18, 2022

Unit Test Results

       1 files         1 suites   2m 9s ⏱️
2 101 tests 2 101 ✔️ 0 💤 0

Results for commit 2f3154a.

♻️ This comment has been updated with latest results.

@vhirtham
Copy link
Collaborator Author

Seems like I missed something but k3d plots are now showing up in the RTD docs:

https://weldx--681.org.readthedocs.build/en/681/tutorials/01_03_geometry.html

nice... have to adjust the text at those sections.

@vhirtham
Copy link
Collaborator Author

@marscher @CagtayFabry There is currently an import warning in all tutorials. If somebody already knows the solution, please let me know. Otherwise I have to investigate. See first cell here: https://weldx--681.org.readthedocs.build/en/681/tutorials/01_03_geometry.html

@CagtayFabry
Copy link
Member

@marscher @CagtayFabry There is currently an import warning in all tutorials. If somebody already knows the solution, please let me know. Otherwise I have to investigate. See first cell here: https://weldx--681.org.readthedocs.build/en/681/tutorials/01_03_geometry.html

good catch!
and interesting, I am not sure how to get rid of this warning or if we can flag both of our extensions versions (0.1.0 from the release and 0.1.1 from current dev) as supported

@CagtayFabry
Copy link
Member

CagtayFabry commented Jan 19, 2022

I have added the path option in a simple form to WeldxFile.info and WeldxFile.show_asdf_header here for convenience, see bff8576 @marscher @vhirtham

Copy link
Member

@CagtayFabry CagtayFabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks (and reads) really nice 👍 🚀

@vhirtham vhirtham merged commit fe21561 into BAMWelDX:master Jan 27, 2022
@vhirtham vhirtham deleted the tutorial_geometry branch January 27, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants