Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix time behavior in tests and filter warnings for pandas 1.4 #689

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

CagtayFabry
Copy link
Member

Changes

  • Fix failing tests due to new pandas version ->seems like pandas added own __add__ functions so that we couldn't use + with a pandas Type on the left-hand side and our Time class on the right-hand side (thanks @vhirtham )
  • filter warnings caused by xarray introduced with pandas 1.4

Checks

  • updated tests

@CagtayFabry
Copy link
Member Author

CagtayFabry commented Jan 26, 2022

This should get rid of a few thousand warnings in tests hopefully 🚀😄
(and clean up your notebooks @marscher 😉) sorry it won't since this is only tests... 🙄 I suggest going back to pandas 1.3 for now

@CagtayFabry CagtayFabry added the tests pytest (and other tests) related label Jan 26, 2022
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #689 (13e6bff) into master (d4c6039) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #689   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files          92       92           
  Lines        6310     6310           
=======================================
  Hits         6051     6051           
  Misses        259      259           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c6039...13e6bff. Read the comment docs.

@CagtayFabry CagtayFabry merged commit 045a054 into master Jan 26, 2022
@CagtayFabry CagtayFabry deleted the pandas_cleanup branch January 26, 2022 16:49
@github-actions
Copy link

github-actions bot commented Jan 26, 2022

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 38s ⏱️ +19s
2 101 tests ±0  2 101 ✔️ +22  0 💤 ±0  0  - 22 

Results for commit 13e6bff. ± Comparison against base commit d4c6039.

♻️ This comment has been updated with latest results.

@marscher
Copy link
Contributor

Eventually it makes sense to pin to a minor of pandas, which has been tested and only upgrade it, if everything works as expected.

@CagtayFabry
Copy link
Member Author

something like pandas>=1.0,<=1.3 ?

I think that would be ok if we have a good workflow release patch versions if new pandas releases work as expected (while still giving some safety)

@marscher
Copy link
Contributor

marscher commented Feb 1, 2022

Yes.

PyPI prohibits uploading patched sources, so this always renders a new micro release just for updating the dependencies. Conda does circumvent this by increasing build numbers. I guess there is no way to avoid this.

Eventually it is too much overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed tests pytest (and other tests) related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants