Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename wxfile asdf header #694

Merged
merged 6 commits into from
Feb 2, 2022

Conversation

marscher
Copy link
Contributor

Changes

  • Refactored/deprecated WeldxFile.show_asdf_header to header.
  • Use packaging.version instead of distutils.version (deprecated).

Related Issues

Closes #688, #693

Checks

  • updated CHANGELOG.rst
  • updated tests
  • updated doc/

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #694 (882e628) into master (2c348c5) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          92       92           
  Lines        6327     6330    +3     
=======================================
+ Hits         6079     6082    +3     
  Misses        248      248           
Impacted Files Coverage Δ
weldx/asdf/util.py 90.20% <66.66%> (ø)
weldx/asdf/file.py 97.08% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c348c5...882e628. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 31, 2022

Unit Test Results

       1 files  ±0         1 suites  ±0   1m 27s ⏱️ -31s
2 101 tests ±0  2 101 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 882e628. ± Comparison against base commit 2c348c5.

♻️ This comment has been updated with latest results.

weldx/asdf/util.py Outdated Show resolved Hide resolved
@marscher marscher requested a review from CagtayFabry February 1, 2022 14:05
@CagtayFabry CagtayFabry linked an issue Feb 1, 2022 that may be closed by this pull request
@marscher marscher merged commit 60cd025 into BAMWelDX:master Feb 2, 2022
@marscher marscher deleted the rename_wxfile_asdf_header branch February 2, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants