Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treat pint.UnitStrippedWarning as error in pytest runs #702

Merged
merged 1 commit into from
Feb 9, 2022
Merged

treat pint.UnitStrippedWarning as error in pytest runs #702

merged 1 commit into from
Feb 9, 2022

Conversation

CagtayFabry
Copy link
Member

Changes

pint.UnitStrippedWarning will be raised as errors in our test suite

Checks

  • updated tests

@CagtayFabry CagtayFabry added tests pytest (and other tests) related no-changelog-entry-needed labels Feb 9, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

Unit Test Results

       1 files  ±0         1 suites  ±0   1m 39s ⏱️ -3s
2 101 tests ±0  2 101 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 29cb545. ± Comparison against base commit ad9e337.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 9, 2022 •
edited
Loading

Codecov Report

Merging #702 (29cb545) into master (ad9e337) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #702   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          92       92           
  Lines        6330     6330           
=======================================
  Hits         6082     6082           
  Misses        248      248

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad9e337...29cb545. Read the comment docs.

vhirtham
vhirtham approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@vhirtham vhirtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm

@CagtayFabry CagtayFabry merged commit ae2dff5 into master Feb 9, 2022
@CagtayFabry CagtayFabry deleted the catch_unit_stripped_warning branch February 9, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhirtham vhirtham vhirtham approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed tests pytest (and other tests) related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CagtayFabry @vhirtham