Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow networkx >2.7.0 #722

Merged
merged 2 commits into from
Mar 14, 2022
Merged

allow networkx >2.7.0 #722

merged 2 commits into from
Mar 14, 2022

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Mar 14, 2022

Changes

  • our code should be good again after 2.7.1 release of networkx

Related Issues

#714

Checks

  • updated CHANGELOG.rst

@CagtayFabry CagtayFabry added the dependencies changes in package dependencies label Mar 14, 2022
@CagtayFabry CagtayFabry requested a review from marscher March 14, 2022 12:24
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #722 (8688064) into master (faac067) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #722   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          92       92           
  Lines        6519     6519           
=======================================
  Hits         6252     6252           
  Misses        267      267           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faac067...8688064. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 14, 2022

Unit Test Results

       1 files  ±0         1 suites  ±0   1m 52s ⏱️ -9s
2 156 tests ±0  2 156 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8688064. ± Comparison against base commit faac067.

♻️ This comment has been updated with latest results.

@marscher
Copy link
Contributor

Do we need to patch this for the already released conda-forge package?

@CagtayFabry
Copy link
Member Author

Do we need to patch this for the already released conda-forge package?

The problem only comes up with 2.7.0 which probably never get's installed now that 2.7.1 is released but I will update the recipe just to keep it in sync with setuptools

@CagtayFabry CagtayFabry marked this pull request as ready for review March 14, 2022 14:43
@CagtayFabry CagtayFabry merged commit 81f04c9 into master Mar 14, 2022
@CagtayFabry CagtayFabry deleted the networkx_271 branch March 14, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies changes in package dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants