Strict quantities

[vhirtham]

Changes

Units are now mandatory and no longer optional in the CoordinateSystemManager and the LocalCoordinateSystem

Related Issues

Closes #682

Checks

• updated CHANGELOG.rst
• updated tests
• updated doc/
• update example/tutorial notebooks
• update manifest file

[github-actions]

Unit Test Results

       1 files  ±  0         1 suites  ±0   2m 34s ⏱️ -2s
2 146 tests  - 17  2 146 ✔️  - 17  0 💤 ±0  0 ❌ ±0 

Results for commit 0aad9d2. ± Comparison against base commit 63d1ce6.

♻️ This comment has been updated with latest results.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

Merging #731 (0aad9d2) into master (63d1ce6) will decrease coverage by 0.04%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   95.89%   95.85%   -0.05%     
==========================================
  Files          92       92              
  Lines        6511     6520       +9     
==========================================
+ Hits         6244     6250       +6     
- Misses        267      270       +3     

Impacted Files	Coverage Δ
weldx/time.py	97.76% <ø> (ø)
weldx/geometry.py	96.59% <77.77%> (-0.21%)	⬇️
weldx/transformations/local_cs.py	96.70% <87.50%> (-0.43%)	⬇️
weldx/asdf/cli/welding_schema.py	97.02% <100.00%> (ø)
weldx/tags/core/geometry/spatial_data.py	100.00% <100.00%> (ø)
...gs/core/transformations/local_coordinate_system.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d1ce6...0aad9d2. Read the comment docs.

[vhirtham]

I think the only things missing are that we need new schema file versions for LCS and CSM with that added unit restriction via wx_units

Only the LCS needed an update, since the CSMs unit restrictions are just a result of the stored LCS instances. I updated the LCS schema version.

By the way, should we have also created a new version for the SpatialData schema?

[marscher]

Thanks you for this improvement.
At the very end I suggest adding a test, which checks the raising of the exceptions, if no unit was provided.

[CagtayFabry]

the only problem left is probably opening old weldx files now since that would require adding the default quantities in the from_yaml conversion

@vhirtham please add a list to the PR comment indicating which classes are affected by this PR
should be fine now