-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use weldx-widgets to reduce dependencies of weldx #749
Conversation
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
==========================================
+ Coverage 95.81% 96.78% +0.96%
==========================================
Files 92 90 -2
Lines 6500 5999 -501
==========================================
- Hits 6228 5806 -422
+ Misses 272 193 -79
Continue to review full report at Codecov.
|
The title left me a bit confused since wxWidgets is a C++ GUI library 😄 |
…to use-wx-widgets
@marscher yes, we should ignore the mypy issues for now. I will start a new PR soon. However, the other linter errors (deepsource) should be fixed. I had a look at the reported issue. If the behavior is intended, just place a corresponding comment to the line so that it is ignored by deepsource. It complains about an open call with an external reference. |
The code triggering this external open issue in _clean_notebook is a private function intended to clean notebooks, but I think this function is only a developer util, so it should be moved outside of the main package. |
since this tool is only a developer utility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@marscher You can just silence the warning with |
cool ! |
Changes
Use weldx-widgets
Related Issues
Closes #746
Checks