Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes #751

Merged
merged 7 commits into from
May 11, 2022
Merged

Minor changes #751

merged 7 commits into from
May 11, 2022

Conversation

marscher
Copy link
Contributor

@marscher marscher commented May 10, 2022 •
edited
Loading

Changes

  • Avoid some code duplications
  • Use weldx.constants._DEFAULT_LEN_UNIT where appropriate
  • Fixed some mypy issues.
  • GHA: doc building uses two jobs instead of "auto" = n physical CPUs.

marscher and others added 4 commits May 10, 2022 14:29
@marscher
update all
583da98
@marscher
fix some mypy issues, reduce code duplication
c792167
@marscher
Merge branch 'master' into minor
3eb050e
@marscher
set sphinx build jobs to 2
47c5815 
background:
"auto" setting will most likely use all physical cpus of the host, but the container would be restricted to use only two cores.
So most jobs will just starve.
@codecov
Copy link

codecov bot commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #751 (ebf06c9) into master (32d8ced) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   95.82%   95.81%   -0.02%     
==========================================
  Files          92       92              
  Lines        6516     6500      -16     
==========================================
- Hits         6244     6228      -16     
  Misses        272      272
Impacted Files Coverage Δ
weldx/types.py 100.00% <ø> (ø)
weldx/constants.py 100.00% <100.00%> (ø)
weldx/welding/groove/iso_9692_1.py 99.52% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d8ced...ebf06c9. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 10, 2022 •
edited
Loading

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 33s ⏱️ -3s
2 146 tests ±0  2 146 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ebf06c9. ± Comparison against base commit 32d8ced.

♻️ This comment has been updated with latest results.

@marscher marscher requested a review from vhirtham May 11, 2022 06:47
@marscher marscher marked this pull request as ready for review May 11, 2022 06:47
vhirtham
vhirtham approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@vhirtham vhirtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marscher marscher merged commit 418cf3d into BAMWelDX:master May 11, 2022
@marscher marscher deleted the minor branch May 11, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhirtham vhirtham vhirtham approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marscher @vhirtham