Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] fix pattern for extlinks, use Sphinx-bundled (up2date) napoleon #766

Merged
merged 6 commits into from
May 31, 2022

Conversation

marscher
Copy link
Contributor

@marscher marscher commented May 30, 2022

Changes

  • Title elements in ext_links require a template %s. The recently released Sphinx version triggered a warning about it.
  • Napoleon used to be loaded as sphinxcontrib.napoleon; However sphinx.ext.napoleon is more recent.

Checks

  • updated doc/

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #766 (0fd4190) into master (b859a54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #766   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files          88       88           
  Lines        6009     6009           
=======================================
  Hits         5819     5819           
  Misses        190      190           
Impacted Files Coverage Δ
weldx/asdf/file.py 96.20% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b859a54...0fd4190. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 30, 2022

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 41s ⏱️ +2s
2 152 tests ±0  2 152 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 0fd4190. ± Comparison against base commit b859a54.

♻️ This comment has been updated with latest results.

@marscher marscher requested a review from vhirtham May 31, 2022 06:48
@marscher marscher merged commit cc3ac01 into BAMWelDX:master May 31, 2022
@marscher marscher deleted the fix_extlinks_and_napoleon branch May 31, 2022 09:48
@vhirtham
Copy link
Collaborator

Thanks for fixing this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants