-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix length computation sympy #770
Fix length computation sympy #770
Conversation
note that the deepsource issues are unrelated to my changes :P |
@vhirtham I've noticed, that using scipy as backend now triggers deprecation warnings like this:
However we need to use scipy to make "Integrate" use the right backend. Do you have a suggestion how to proceed? |
xref: sympy/sympy#20294 |
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 88 88
Lines 6014 6017 +3
=======================================
+ Hits 5820 5823 +3
Misses 194 194
Continue to review full report at Codecov.
|
I silenced it for the future ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Curious if this fixes some of the old computations issues I had.
Let me know if that helped with your old issues. |
this looks great, nice find ! |
Changes
If we use the
Integrate
function in SymPy lambdify, we need to use "scipy" as method, "numpy" is not sufficient.xref: sympy/sympy#20134
Related Issues
Closes #725
Checks
updated doc/update example/tutorial notebooksupdate manifest file