Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix length computation sympy #770

Merged
merged 11 commits into from
Jun 13, 2022

Conversation

marscher
Copy link
Contributor

@marscher marscher commented Jun 9, 2022

Changes

If we use the Integrate function in SymPy lambdify, we need to use "scipy" as method, "numpy" is not sufficient.
xref: sympy/sympy#20134

Related Issues

Closes #725

Checks

  • updated CHANGELOG.rst
  • updated tests
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@marscher
Copy link
Contributor Author

marscher commented Jun 9, 2022

note that the deepsource issues are unrelated to my changes :P

@marscher
Copy link
Contributor Author

marscher commented Jun 9, 2022

@vhirtham I've noticed, that using scipy as backend now triggers deprecation warnings like this:

DeprecationWarning: scipy.sin is deprecated and will be removed in SciPy 2.0.0, use numpy.sin instead

However we need to use scipy to make "Integrate" use the right backend. Do you have a suggestion how to proceed?

@marscher marscher requested a review from vhirtham June 9, 2022 11:12
@marscher
Copy link
Contributor Author

marscher commented Jun 9, 2022

xref: sympy/sympy#20294

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #770 (85dc858) into master (eac3ca0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #770   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          88       88           
  Lines        6014     6017    +3     
=======================================
+ Hits         5820     5823    +3     
  Misses        194      194           
Impacted Files Coverage Δ
weldx/core.py 93.41% <ø> (ø)
weldx/geometry.py 96.61% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac3ca0...85dc858. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Unit Test Results

2 153 tests  +1   2 153 ✔️ +1   2m 24s ⏱️ -11s
       1 suites ±0          0 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 85dc858. ± Comparison against base commit eac3ca0.

♻️ This comment has been updated with latest results.

@marscher marscher marked this pull request as ready for review June 9, 2022 11:26
@vhirtham
Copy link
Collaborator

note that the deepsource issues are unrelated to my changes :P

I silenced it for the future ;)

Copy link
Collaborator

@vhirtham vhirtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Curious if this fixes some of the old computations issues I had.

@marscher marscher merged commit bea885f into BAMWelDX:master Jun 13, 2022
@marscher marscher deleted the fix_length_computation_sympy branch June 13, 2022 13:04
@marscher
Copy link
Contributor Author

Let me know if that helped with your old issues.

@CagtayFabry
Copy link
Member

this looks great, nice find !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize length calculation of DynamicBaseSegment
3 participants