-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for quality standards and update the quality standard tutorial #777
Add a test for quality standards and update the quality standard tutorial #777
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Totally forgot about the issue that quality standards affect the whole pytest run. That's why the tests are currently failing. The question is how we want to advance. We can either remove the test and rely on the modified notebook to catch future bugs, or we can exclude the test from the regular pytest run and add a separate run just for this test. What do you think? |
Ah yes, that is tricky when the whole environment is affected... I would suggest the following: weldx/.github/workflows/pytest.yml Lines 78 to 85 in 2af3da3
I hope that works |
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 88 88
Lines 6017 6017
=======================================
Hits 5823 5823
Misses 194 194 |
Changes
Since version
0.5.0
the quality standard tutorial was outdated. The presented standard did not override the schema and the subsequent code didn't produce the exceptions that were mentioned in the text. Due to the fact that it wasn't checked if the exception was actually raised, this wasn't noticed. I added a new test for quality standards and adjusted the tutorial too so that this can't happen again.Checks
update manifest file