Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section about time-dependent SpatialData to CSM tutorial #792

Merged
merged 6 commits into from
Aug 2, 2022
Merged

Add section about time-dependent SpatialData to CSM tutorial #792

merged 6 commits into from
Aug 2, 2022

Conversation

vhirtham
Copy link
Collaborator

@vhirtham vhirtham commented Jul 28, 2022 •
edited
Loading

Changes

Add section about time-dependent SpatialData to CSM tutorial

Checks

  • updated CHANGELOG.rst
  • updated tests
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@vhirtham vhirtham added documentation Improvements or additions to documentation transformations everything related to the LCS / CSM tutorials tutorials or code examples labels Jul 28, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Jul 28, 2022 •
edited
Loading

Test Results

2 185 tests  ±0   2 184 ✔️ ±0   2m 47s ⏱️ -41s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit 2adf1ce. ± Comparison against base commit bbab081.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 29, 2022 •
edited
Loading

Codecov Report

Merging #792 (2adf1ce) into master (bbab081) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          88       88           
  Lines        6025     6025           
=======================================
  Hits         5837     5837           
  Misses        188      188
Impacted Files Coverage Δ
weldx/transformations/cs_manager.py 98.60% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@vhirtham vhirtham marked this pull request as ready for review July 29, 2022 11:09
@vhirtham vhirtham requested a review from marscher August 1, 2022 13:36
marscher
marscher approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@marscher marscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this interesting (and sophisticated) example to the documentation. I didn't spot anything to correct or improve. Very good job!

@vhirtham vhirtham merged commit dd10d4e into BAMWelDX:master Aug 2, 2022
@vhirtham vhirtham deleted the CSM_tut_update branch August 2, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marscher marscher marscher approved these changes

@AndreasPittner AndreasPittner Awaiting requested review from AndreasPittner

@CagtayFabry CagtayFabry Awaiting requested review from CagtayFabry

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation transformations everything related to the LCS / CSM tutorials tutorials or code examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vhirtham @marscher