Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k3d in RTD documentation #798

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Conversation

vhirtham
Copy link
Collaborator

@vhirtham vhirtham commented Aug 29, 2022

Changes

k3d plots are currently broken. Have a look at the plots here

Checks

  • updated CHANGELOG.rst
  • updated tests
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@vhirtham vhirtham added bug Something isn't working no-changelog-entry-needed tutorials tutorials or code examples visualization plotting and related functions labels Aug 29, 2022
@github-actions
Copy link

github-actions bot commented Aug 29, 2022

Test Results

2 185 tests  ±0   2 184 ✔️ ±0   2m 29s ⏱️ -49s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit b39a7bd. ± Comparison against base commit fdbba15.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #798 (b39a7bd) into master (fdbba15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #798   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          88       88           
  Lines        6025     6025           
=======================================
  Hits         5837     5837           
  Misses        188      188           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vhirtham
Copy link
Collaborator Author

Verbally approved by @CagtayFabry :)

@vhirtham vhirtham merged commit 5deeeeb into BAMWelDX:master Aug 29, 2022
@vhirtham vhirtham deleted the fix_k3d_in_doc branch August 29, 2022 09:30
@marscher
Copy link
Contributor

So it was just ipywidgets-8 being incompatible?

@vhirtham
Copy link
Collaborator Author

So it was just ipywidgets-8 being incompatible?

yes, this was the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-changelog-entry-needed tutorials tutorials or code examples visualization plotting and related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants