Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rtd_environment.yml #806

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Update rtd_environment.yml #806

merged 2 commits into from
Sep 26, 2022

Conversation

CagtayFabry
Copy link
Member

Changes

use older nbformat due to MissingIDFieldWarning

Checks

  • updated doc/

@CagtayFabry CagtayFabry added documentation Improvements or additions to documentation no-changelog-entry-needed dependencies changes in package dependencies labels Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #806 (a773535) into master (0c5ab61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files          81       81           
  Lines        5380     5380           
=======================================
  Hits         5208     5208           
  Misses        172      172           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Test Results

2 185 tests  ±0   2 184 ✔️ ±0   2m 37s ⏱️ -1s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 9661972. ± Comparison against base commit 0c5ab61.

@github-actions
Copy link

github-actions bot commented Sep 26, 2022

Test Results

2 185 tests  ±0   2 184 ✔️ ±0   3m 39s ⏱️ + 1m 1s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit a773535. ± Comparison against base commit 0c5ab61.

♻️ This comment has been updated with latest results.

@marscher
Copy link
Contributor

I think we would just need to fix our notebooks, e.g. each cell has to have an ID.

@CagtayFabry
Copy link
Member Author

I think we would just need to fix our notebooks, e.g. each cell has to have an ID.

that would probably be the right solution 😁
I am not sure if the IDs get removed by some kind of script/hook atm though

If this doesn't work as a quick fix I am fine to leave it for now until we fix the notebooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies changes in package dependencies documentation Improvements or additions to documentation no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants