Conda recipe fix deps #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda does not know the conecpt of optional dependencies, so we install all optional features from pyproject.toml to ensure everything is working. The test dependencies are also obtained from pyproject.toml
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
=======================================
Coverage 96.80% 96.80%
=======================================
Files 81 81
Lines 5380 5380
=======================================
Hits 5208 5208
Misses 172 172 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
great solution, thank you! |
CagtayFabry
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since conda does not know the concept of optional dependencies, so we install
all optional features from pyproject.toml to ensure everything is
working.
The test dependencies are also obtained from pyproject.toml