Split up core in smaller sub modules #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pression broke) actually this is very strange, as the relative import triggers a behaviour to use relative import all over the place. The weldx.util.util pkg imports an attr from asdf, but this import would be tried to resolve by Python (3.10) to the weldx internal "asdf" package.
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
==========================================
+ Coverage 96.80% 97.25% +0.44%
==========================================
Files 81 82 +1
Lines 5380 4913 -467
==========================================
- Hits 5208 4778 -430
+ Misses 172 135 -37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
In my opinion the code is better maintainable, if modules are kept smaller. The complains of static analysis are not new, but now show up as being newly introduced. |
CagtayFabry
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Split up core in smaller sub modules, e.g. generic_series and mathematical_expression and so forth.