Unpin maximum Python version #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
=======================================
Coverage 96.83% 96.83%
=======================================
Files 92 92
Lines 6071 6071
=======================================
Hits 5879 5879
Misses 192 192
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Now we got the first evidence that pinning Python for libraries is a bad idea. Weldx-widgets depends on weldx, but this cannot be installed for Python 3.11. So it is an expected failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We allow future versions again. A very detailed discussion why pinning maximum versions can be found here: https://iscinumpy.dev/post/bound-version-constraints/
Also fixed some dataclasses in asdf.tags.debug
TLDR:
Never cap Python, it is fundamentally broken at the moment. Also, even packing capping has negative consequences that can produce unexpected solves.
Related Issues
Closes #836
Checks