Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WXFile] determine widget usage by runtime env in _ipython_display_ #848

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

marscher
Copy link
Contributor

Fixes #846

Changes

In _ipython_display_ we assumed, that it will only be called in a Jupyter lab environment. This ain't true - within a Sphinx environment it's also called. So we just let this state be determined automatically.

Related Issues

Closes #846

Checks

  • updated CHANGELOG.rst
  • updated tests
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #848 (6126717) into master (d1263a4) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage   96.60%   96.59%   -0.02%     
==========================================
  Files          95       95              
  Lines        6222     6222              
==========================================
- Hits         6011     6010       -1     
- Misses        211      212       +1     
Impacted Files Coverage Δ
weldx/asdf/file.py 96.27% <ø> (ø)
weldx/asdf/util.py 90.88% <0.00%> (-0.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Test Results

2 187 tests  ±0   2 186 ✔️ ±0   2m 36s ⏱️ -47s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 6126717. ± Comparison against base commit d1263a4.

@marscher
Copy link
Contributor Author

Now the extended notebook about WXfile renders correctly (https://weldx--848.org.readthedocs.build/en/848/tutorials/weldxfile.html)

@marscher marscher merged commit e7d510f into BAMWelDX:master Jan 30, 2023
@marscher marscher deleted the fix_846 branch January 30, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] WeldxFile output in notebooks renders to IPython.display.JSON in jupyterhub environment
1 participant