Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore jupyter folders #849

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

CagtayFabry
Copy link
Member

Changes

ignore .ipynb_checkpoints folders in pytest discovery

@marscher
Copy link
Contributor

marscher commented Feb 1, 2023

why would we have these in the root directory?

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Test Results

2 187 tests  ±0   2 186 ✔️ ±0   2m 30s ⏱️ - 1m 2s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 76268c5. ± Comparison against base commit e7d510f.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #849 (76268c5) into master (d1263a4) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
- Coverage   96.60%   96.59%   -0.02%     
==========================================
  Files          95       95              
  Lines        6222     6222              
==========================================
- Hits         6011     6010       -1     
- Misses        211      212       +1     
Impacted Files Coverage Δ
weldx/asdf/file.py 96.27% <ø> (ø)
weldx/asdf/util.py 90.88% <0.00%> (-0.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CagtayFabry
Copy link
Member Author

why would we have these in the root directory?

jupyter tends to create a lot of temporary files in those folders (e.g. when opening a .py file)
They don't pop up in the root dir, the exclude works in subfolders

@CagtayFabry CagtayFabry merged commit c04bfda into BAMWelDX:master Feb 1, 2023
@CagtayFabry CagtayFabry deleted the update_pytest_cfg branch February 1, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants