[pre-commit.ci] pre-commit autoupdate #862
Conversation
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
updates: - [github.com/psf/black: 23.1.0 → 23.3.0](psf/black@23.1.0...23.3.0) - [github.com/charliermarsh/ruff-pre-commit: v0.0.259 → v0.0.260](astral-sh/ruff-pre-commit@v0.0.259...v0.0.260) - [github.com/abravalheri/validate-pyproject: v0.12.1 → v0.12.2](abravalheri/validate-pyproject@v0.12.1...v0.12.2) - [github.com/nbQA-dev/nbQA: 1.6.4 → 1.7.0](nbQA-dev/nbQA@1.6.4...1.7.0)
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 95 95
Lines 6238 6238
=======================================
Hits 6018 6018
Misses 220 220 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I'm in favor of ignoring |
yes if we can ignore that for the tutorials / tests that would be great |
| [tool.nbqa.addopts] | ||
| ruff = [ | ||
| "--extend-ignore=B018" | ||
| ] |
There was a problem hiding this comment.
I don't know how to add per-file-ignore for nbqa (see nbQA-dev/nbQA#730) but I think this does the same since we only have notebooks in the tutorials @marscher
| @@ -233,7 +233,7 @@ def test_operation_on_closed(self): | |||
|
|
|||
| # cannot access closed handles | |||
| with pytest.raises(RuntimeError): | |||
| self.fh.file_handle | |||
| self.fh.file_handle # noqa: B018 | |||
There was a problem hiding this comment.
we should report this as false positive to the Ruff repo, IMO.
updates: