update to new Validator interface #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CagtayFabry
commented
Apr 5, 2023
| ------ | ||
| asdf.ValidationError | ||
| schema_property = "wx_unit" | ||
| tags = ["**"] |
There was a problem hiding this comment.
Ideally we would only list weldx tags here but selecting the validator for every node preserves the legacy behavior for untagged nodes
see previous discussion here asdf-format/asdf#1050 (comment)
|
tests passing now with |
CagtayFabry
added
ASDF
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
==========================================
+ Coverage 96.47% 96.48% +0.01%
==========================================
Files 95 94 -1
Lines 6238 6230 -8
==========================================
- Hits 6018 6011 -7
+ Misses 220 219 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
marscher
approved these changes
Apr 5, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
asdfdependency to 2.15Related Issues
asdf-format/asdf#1012
asdf-format/asdf#1050
Checks