Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantify xarray parameters in MathematicalExpression #864

Merged

Conversation

CagtayFabry
Copy link
Member

Changes

  • quantify unitless xarray input parameters as dimensionless in MathematicalExpression (same as non quantity numeric inputs)
  • update pint-xarray dependency to 0.3 for updated pint.quantify() behavior

Related Issues

Closes #860

Checks

  • updated CHANGELOG.rst
  • updated tests

@CagtayFabry CagtayFabry added bug Something isn't working ASDF everything ASDF related (python + schemas) xarray issues related to handling xarray objects units unit handling and pint labels Apr 5, 2023
@CagtayFabry CagtayFabry requested a review from marscher April 5, 2023 13:07
@CagtayFabry CagtayFabry enabled auto-merge April 5, 2023 13:07
@CagtayFabry CagtayFabry added the dependencies changes in package dependencies label Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Test Results

2 189 tests  +2   2 188 ✔️ +2   3m 47s ⏱️ + 1m 9s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 0f7d096. ± Comparison against base commit 91140eb.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #864 (0f7d096) into master (91140eb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
+ Coverage   96.47%   96.49%   +0.01%     
==========================================
  Files          95       95              
  Lines        6238     6242       +4     
==========================================
+ Hits         6018     6023       +5     
+ Misses        220      219       -1     
Impacted Files Coverage Δ
weldx/core/math_expression.py 98.59% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CagtayFabry CagtayFabry added this pull request to the merge queue Apr 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 5, 2023
@CagtayFabry CagtayFabry merged commit bf5bc70 into BAMWelDX:master Apr 6, 2023
@CagtayFabry CagtayFabry deleted the raise_me_dataarray_unitless branch April 6, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) bug Something isn't working dependencies changes in package dependencies units unit handling and pint xarray issues related to handling xarray objects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serializing MathematicalExpression with not quantified xarray.DataArray fails
2 participants