1 polish the structure of the repo and add nextjs generated gui #2
Conversation
Pull Request Test Coverage Report for Build 19924101823Details
💛 - Coveralls |
JosePizarro3
left a comment
JosePizarro3
left a comment
There was a problem hiding this comment.
Some minor comments. I will go through installing this locally, checking the README, and let you know how it goes.
I didn't review the frontend. Once I launch this I will take a look and give some comments.
There was a problem hiding this comment.
I will go through the installation using this README.md and let you know
JosePizarro3
left a comment
JosePizarro3
left a comment
There was a problem hiding this comment.
just some minor comments, I will rewrite the README later
| ) | ||
|
|
||
|
|
||
| class UpdateSchema(BaseModel): |
| schema_documents = list(schemas_collection.find()) | ||
|
|
||
| # Verbose loop: clarify what we're iterating over and why | ||
| for schema_document in schema_documents: |
There was a problem hiding this comment.
to be honest, I am not sure what this logic does. You get the original_id from schema_document["_id"] and then you overwrite schema_document["_id"] with the original_id (which is already a string, shouldn't mutate to another type at any moment)
I think this method just needs to return list(schemas_collection.find())
| Args: | ||
| schema (SchemaDefinition): The schema data to insert. | ||
| Returns: | ||
| dict: The ID of the inserted schema. |
There was a problem hiding this comment.
the description of this is a bit different. Should be:
Returns:
dict: A dictionary with key being the ID of the inserted schema, and value the actual inserted schema
|
Nice |
Description Message, I am creating a "Pull Request".