Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Description to Module View #13

Merged
merged 5 commits into from
Apr 13, 2020

Conversation

logicsec-zz
Copy link

@logicsec-zz logicsec-zz commented Apr 12, 2020

Fixes #11

Type of change

Feature Request

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • vue-cli-service lint

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vinnybod
Copy link
Contributor

I just have a few styling tweeks and then I think this is good to go.

Can we wrap the title for each field in a <b></b> tag like we do here and display the comments and author without the brackets by joining them like we do here? .join(', ') for author and .join('\n') for comments. And then just removing the <br> since <p> seems to provide enough spacing.

The result:
Screen Shot 2020-04-12 at 6 25 21 PM

@logicsec-zz
Copy link
Author

Yea I think that works for me :)

@vinnybod
Copy link
Contributor

Okay cool, we can merge it to dev once you push those changes up!

@logicsec-zz
Copy link
Author

Should see it now :)

src/views/Modules.vue Outdated Show resolved Hide resolved
Co-Authored-By: Vincent Rose <vrose04@gmail.com>
@vinnybod
Copy link
Contributor

Thanks! This will go into the next release

@vinnybod vinnybod merged commit 2cca42f into BC-SECURITY:dev Apr 13, 2020
@logicsec-zz logicsec-zz deleted the module-description branch April 13, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants