Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raises XLRDError is problematic #159

Closed
prjemian opened this issue May 29, 2019 · 0 comments · Fixed by #160
Closed

raises XLRDError is problematic #159

prjemian opened this issue May 29, 2019 · 0 comments · Fixed by #160
Assignees
@prjemian
Labels
task Something to be done.
Milestone
v1.1.7

Comments

@prjemian
Copy link
Contributor

In utils.ExcelDatabaseFileBase().parse() the calls to pandas.read_excel() could raise XLRDError if the wrong type of file is presented. It would be easier on clients of apstools to re-raise this with a local exception so the client does not need to also import the package defining XLRDError.
@prjemian prjemian added the task Something to be done. label May 29, 2019
@prjemian prjemian added this to the milestone-2019-09 milestone May 29, 2019
@prjemian prjemian self-assigned this May 29, 2019
prjemian added a commit that referenced this issue May 29, 2019
@prjemian
fixes #159
1a9a39a
@prjemian prjemian mentioned this issue May 29, 2019
Merged
@prjemian prjemian modified the milestones: milestone-2019-09, v1.1.7 Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
task Something to be done.
Projects
None yet
Milestone
v1.1.7
Development

Successfully merging a pull request may close this issue.

run a command list text or Excel file BCDA-APS/apstools
1 participant
@prjemian