Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motor limits updated outside of bluesky #284

Closed
prjemian opened this issue Feb 15, 2020 · 1 comment
Closed

motor limits updated outside of bluesky #284

prjemian opened this issue Feb 15, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@prjemian
Copy link
Contributor

prjemian commented Feb 15, 2020

USAXS recently reported LimitError: Value 140.0 outside of range: [-113.4, 118.0]. This error comes up when the motor limits are changed outside of ophyd. The devices.EpicsMotorLimitsMixin class needs to capture and respond to CA monitor events on the limits.

Also noted in bluesky/ophyd#802

@prjemian prjemian added the bug label Feb 15, 2020
@prjemian prjemian added this to the 1.1.19 milestone Feb 15, 2020
@prjemian prjemian self-assigned this Feb 15, 2020
@prjemian
Copy link
Contributor Author

The limits are contained in the ophyd.signal.EpicsSignalBase._metadata dictionary. Simply updating this dictionary is not sufficient, the initial values will be reset on the next motor move. But, there is a _metadata_changed() method that will make all the necessary changes. It needs the PV name and a dictionary of the new metadata.

prjemian added a commit that referenced this issue Feb 16, 2020
prjemian added a commit that referenced this issue Feb 16, 2020
prjemian added a commit that referenced this issue Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant