Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor devices, utils, ... into subdirectories #286

Closed
prjemian opened this issue Feb 15, 2020 · 5 comments
Closed

refactor devices, utils, ... into subdirectories #286

prjemian opened this issue Feb 15, 2020 · 5 comments
Assignees
Milestone

Comments

@prjemian
Copy link
Contributor

Project is growing and the various files have many definitions each. Divide files (such as devices.py) into directories (such as devices) and make modules as appropriate.

@prjemian prjemian added this to the 1.1.20 milestone Feb 15, 2020
@prjemian prjemian self-assigned this Feb 15, 2020
prjemian added a commit that referenced this issue Feb 15, 2020
prjemian added a commit that referenced this issue Feb 15, 2020
prjemian added a commit that referenced this issue Feb 15, 2020
prjemian added a commit that referenced this issue Feb 16, 2020
@prjemian
Copy link
Contributor Author

Changeset 4b8ef0e belongs to this issue, not #288

@prjemian
Copy link
Contributor Author

Not convinced these changes result in a positive improvement to the package. Beginning to look more like a re-arrangement that needs more work, causes more work, and might not make the package easier to understand and maintain.

Identify the substantive changes in this branch and create issues for each, then resolve each in master branch.

@prjemian
Copy link
Contributor Author

Create a PR to highlight those changes.

@prjemian
Copy link
Contributor Author

new issues

Here are the changesets involved in the branch:

prjemian added a commit that referenced this issue Feb 18, 2020
prjemian added a commit that referenced this issue Feb 18, 2020
@prjemian
Copy link
Contributor Author

All changes recovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant