Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError from db.hs #315

Closed
prjemian opened this issue May 12, 2020 · 2 comments
Closed

AttributeError from db.hs #315

prjemian opened this issue May 12, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@prjemian
Copy link
Contributor

This line: https://github.com/BCDA-APS/apstools/blob/master/apstools/examples.py#L63 generates this error:

AttributeError: hs

Comes from here: https://github.com/bluesky/databroker/blob/0366a8925d50076de7ab9327fcc7e9e19dc8fd57/databroker/_core.py#L902-L912

which means this must change due to changes in databroker

@prjemian prjemian added the bug label May 12, 2020
@prjemian prjemian added this to the 1.2.4 milestone May 12, 2020
@prjemian prjemian self-assigned this May 12, 2020
@danielballan
Copy link

It looks like our tests didn't cover this, so it was passed over in our efforts to make databroker.v1.Broker match the API of databroker.v0.Broker. If you think this will come up many places, we can add an hs accessor to match the v0 API, but if changing db.hs.find_run_starts to db() (the standard v1 way) or db.v2.search (the recommended v2 way) fixes the issue, that would be the easier path for us.

prjemian added a commit that referenced this issue May 28, 2020
@prjemian
Copy link
Contributor Author

Since apstools.utils.listruns() provides this capability, the example function should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants