Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code style should pass flake8 #481

Closed
prjemian opened this issue Jan 13, 2021 · 0 comments · Fixed by #483
Closed

code style should pass flake8 #481

prjemian opened this issue Jan 13, 2021 · 0 comments · Fixed by #483
Milestone

Comments

@prjemian
Copy link
Contributor

All code modules should be made to pass flake8, then add code style (flake8) testing to the CI (github workflow). The command tool black -l 75 can be used to reformat files to become compliant. Since black is agressive about styling, there may be some sections that should be excluded from the formatting (yet these sections must still pass flake8).

    # this line will be checked by black
    data = [1,2,3]

    # this line will not be checked by black
    # fmt: off
    a = data[-1]
    # fmt: off

    # this line will be checked by black
    b = data[:2]

@gfabbris: You were interested in this feature of black

@prjemian prjemian added this to the 1.4.1 milestone Jan 13, 2021
@prjemian prjemian modified the milestones: 1.4.1, 1.4.0 Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
prjemian added a commit that referenced this issue Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant