Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabJack T7 support #879

Closed
canismarko opened this issue Oct 12, 2023 · 8 comments · Fixed by #890
Closed

LabJack T7 support #879

canismarko opened this issue Oct 12, 2023 · 8 comments · Fixed by #890

Comments

@canismarko
Copy link
Collaborator

I was going to work on this, but was wondering what the best way forward is.

I have a LabJack T7 that I'm using to measure voltage signals on the differential analog inputs.

Synapps 6.2.1 includes labjack support from April 2022. In Nov 2022, @MarkRivers rewrote the EPICS support to use the vendor's LJM library, so at some point (synapps 6.3?) that will be available. I haven't dug into the record enough, but I suspect that some of the PVs are different.

@kurtgoetze helped me get the old labjack support working, and I could submit a PR to provide a device for it. But would it be better to get the new version working at our beamline and then write an ophyd device for that, knowing that it won't actually be useful for people using synapps 6.2.1 or earlier?

@canismarko canismarko self-assigned this Oct 12, 2023
@MarkRivers
Copy link

I think the PVs are indeed different for the new driver.

@prjemian
Copy link
Contributor

Versioned support seems reasonable (some version info as part of the device name, that is).

@kurtgoetze
Copy link

I would use the newer support where/when possible.

@prjemian
Copy link
Contributor

Will we need to support both databases?

@MarkRivers
Copy link

I think that few enough Bluesky users were using the old LabJack driver that only supporting the new one makes sense.

@canismarko
Copy link
Collaborator Author

Thanks for the input. I will work on the most recent labjack support then. Once we get it working in the IOC, I'll get started on the Ophyd device.

@prjemian
Copy link
Contributor

@canismarko: Any progress?

@canismarko
Copy link
Collaborator Author

@canismarko: Any progress?

Yeah, some. I got the IOC running, and made a little progress on a device in haven for using the analog inputs to start.

I just finished something else I needed to get done before working on the labjack support more, but I should have some time soon. Sorry for the delay.

https://github.com/spc-group/haven/blob/main/src/haven/instrument/labjack.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants