Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: SPEC filewriter scan numbering and newfile() when file exists #138

Merged
merged 20 commits into from
May 9, 2019

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented May 9, 2019

resolve problems with newfile() when file exists

@prjemian prjemian added this to the milestone-2019-09 milestone May 9, 2019
@prjemian prjemian changed the title Spec newfile 128 BUG: SPEC filewriter scan numbering and newfile() when file exists May 9, 2019
@prjemian
Copy link
Contributor Author

prjemian commented May 9, 2019

coveralls reports a big drop in number of lines tested in filewriters.py. This reduction is a false observation since the number of tests has increased from 1 to 8. What it means is that there is more code to be tested. The coveralls web page highlights in red what has not been tested.

tl;dr: acceptable as-is

@prjemian prjemian merged commit 16503d4 into master May 9, 2019
@prjemian prjemian deleted the spec_newfile_128 branch May 9, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant