Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listruns succeeds even when number of existing runs is less than requested #331

Merged
merged 4 commits into from
Jun 25, 2020

Conversation

prjemian
Copy link
Contributor

fixes #330

@prjemian prjemian added the bug label Jun 25, 2020
@prjemian prjemian added this to the 1.2.6 milestone Jun 25, 2020
@prjemian prjemian self-assigned this Jun 25, 2020
@prjemian
Copy link
Contributor Author

travis ran successfully but py36 build reported this error:

======================================================================

ERROR: test_listruns (tests.test_utils.Test_With_Database)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "tests/../tests/test_utils.py", line 245, in test_listruns

    db=self.db,

  File "tests/../tests/../apstools/utils.py", line 324, in listruns

    runs = db[-min(abs(num), len(db.v2.items())):]

TypeError: object of type 'generator' has no len()

@prjemian
Copy link
Contributor Author

All travis builds (py36, py37, py38) reported this error.

Why a reported error from testing but travis reports success?

@prjemian prjemian merged commit 54e098b into master Jun 25, 2020
@prjemian prjemian deleted the 330-listruns branch June 25, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listruns: IndexError: Catalog only contains 3 runs.
1 participant