Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils.OverrideParameters class #534

Merged
merged 13 commits into from
Sep 24, 2021
Merged

Add utils.OverrideParameters class #534

merged 13 commits into from
Sep 24, 2021

Conversation

prjemian
Copy link
Contributor

Fix #533

@prjemian prjemian added this to the 1.5.2 milestone Sep 15, 2021
@prjemian prjemian self-assigned this Sep 15, 2021
@prjemian prjemian changed the title Add OverrideParameters Add utils.OverrideParameters class Sep 15, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2021

This pull request introduces 1 alert when merging a294608 into 608f95c - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2021

This pull request introduces 1 alert when merging 39bbdf5 into 608f95c - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2021

This pull request introduces 1 alert when merging 9f65705 into 40180d1 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2021

This pull request introduces 3 alerts and fixes 1 when merging ad1bdcf into 40180d1 - view on LGTM.com

new alerts:

  • 3 for Unused import

fixed alerts:

  • 1 for 'import *' may pollute namespace

@prjemian
Copy link
Contributor Author

prjemian commented Sep 24, 2021

@gfabbris Recognizing that are involved with experiments, I'm inclined to merge this PR if it passes tests this AM. (It begins a reorganization of utils into a new _utils sub-module that can improve maintenance of this package).

@prjemian prjemian merged commit 89fe147 into main Sep 24, 2021
@prjemian prjemian deleted the 533-UserOverride branch September 24, 2021 14:38
@lgtm-com
Copy link

lgtm-com bot commented Sep 24, 2021

This pull request introduces 3 alerts and fixes 1 when merging 24436a4 into 806c014 - view on LGTM.com

new alerts:

  • 3 for Unused import

fixed alerts:

  • 1 for 'import *' may pollute namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hoist UserOverride from APS USAXS
1 participant