-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove target_attr, keep target signal #535
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work well for some devices in which the setpoint changes when a ramp is used. For example, this is the case for the lakeshore 340. So, it should be
diff = self.readback.get() - self.target.get()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
setpoint
is the ultimate temperature where the controller is headed. The_target
is the interim required value for the temperature control loop. (For example, a controller's PID loop will ramp_target
as the immediate objective to calculate the following error:readback - _target
.) This_target
value may be changed incrementally (ramped) by the controller for a controlled transition from current tosetpoint
. We do not need to examine the controller's interim_target
to determine if the controller has reached the requested temperature.Definitely:
done = |readback - setpoint| <= tolerance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the Lakeshore 340 EPICS supports ramps the setpoint PV. Thus I think it's not great to call it setpoint in EPICS and target in Bluesky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're saying the EPICS Lakeshore support uses
setpoint
for the interim setpoint of the ramp?Doesn't the Lakeshore have a PV that reports where it is headed? That's the PV to be called
setpoint
in Bluesky to be consistent with how it is used in other positioners, such as EpicsMotor.The PTC10 has both: a setpoint where the controller is headed (that is
setpoint
in bluesky) and a setpoint for the PID loop (that wouldtarget
in bluesky but this interim goal is not interesting to the user).An interesting case is when
|target - setpoint| <= tolerance
, that's when we expect to be close enough that|readback- setpoint| <= tolerance
could becomeTrue
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would use this for more controllers than the Lakeshore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gfabbris Can you review again?