Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor from unittest to pytest #547

Merged
merged 20 commits into from
Oct 6, 2021
Merged

refactor from unittest to pytest #547

merged 20 commits into from
Oct 6, 2021

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Oct 4, 2021

@prjemian prjemian added this to the 1.5.3 milestone Oct 4, 2021
@prjemian prjemian self-assigned this Oct 4, 2021
@prjemian prjemian marked this pull request as draft October 4, 2021 22:20
@prjemian prjemian marked this pull request as ready for review October 5, 2021 05:09
@prjemian
Copy link
Contributor Author

prjemian commented Oct 5, 2021

Needs testing on APS workstation

@prjemian
Copy link
Contributor Author

prjemian commented Oct 5, 2021

Can anyone review by the end of this week?

@prjemian
Copy link
Contributor Author

prjemian commented Oct 6, 2021

This reorganizes the unit tests and begins testing with a real EPICS IOC. It is needed for #549 so it would be most useful to merge before 2021-10-07.

@prjemian prjemian mentioned this pull request Oct 6, 2021
Merged
prjemian
prjemian commented Oct 6, 2021
View reviewed changes
apstools/beamtime/apsbss.py Outdated Show resolved Hide resolved
prjemian
prjemian commented Oct 6, 2021
View reviewed changes
Copy link
Contributor Author

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-consider the timeout in the library file, as noted.

@prjemian prjemian assigned prjemian and unassigned prjemian Oct 6, 2021
@prjemian prjemian merged commit 6a7163c into main Oct 6, 2021
@prjemian prjemian deleted the 447-pytest branch October 6, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfabbris gfabbris Awaiting requested review from gfabbris

@jkirchman jkirchman Awaiting requested review from jkirchman

@jsullivan-anl jsullivan-anl Awaiting requested review from jsullivan-anl

@mdwyman mdwyman Awaiting requested review from mdwyman

@strempfer strempfer Awaiting requested review from strempfer

Assignees

@prjemian prjemian

Labels
testing
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.

switch unit testing to py.test
1 participant
@prjemian