Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to updated PVs and commented out ones which cannot be found #981

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Change to updated PVs and commented out ones which cannot be found #981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions apstools/devices/aps_machine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class ApsMachineParametersDevice(Device):

"""

current = Component(EpicsSignalRO, "S:SRcurrentAI")
current = Component(EpicsSignalRO, "S-DCCT:CurrentM")
lifetime = Component(EpicsSignalRO, "S:SRlifeTimeHrsCC")
aps_cycle = Component(ApsCycleDM)
machine_status = Component(EpicsSignalRO, "S:DesiredMode", string=True)
Expand All @@ -88,12 +88,18 @@ class ApsMachineParametersDevice(Device):
# 'Stored Beam',
# 'Delivered Beam',
# 'MAINTENANCE')
shutter_permit = Component(EpicsSignalRO, "ACIS:ShutterPermit", string=True)

# shutter_permit = Component(EpicsSignalRO, "ACIS:ShutterPermit", string=True) # Not Found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if I can find this PV (or its replacement) on one of the other screens...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A beamline-independent PV is not obvious. Another way is to do a recursive grep through the screen files, such as:

grep -R ShutterPermit . | grep ACIS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./asdops/screens/SRcomfort.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRcomfort.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRcomfort.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInj24s.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInjHybrid.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRcomfort_2015.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRcomfort_2015.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInj324s.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInj24s_P0.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInj324s_P0.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInjHybrid_P0.adl: chan="ACIS:ShutterPermit"


Yet, this PV does not respond to `caget`


shutter_status = Component(EpicsSignalRO, "RF-ACIS:FePermit:Sect1To35IdM.RVAL", string = True)
shutters_open = Component(EpicsSignalRO, "NoOfShuttersOpenA")
fill_number = Component(EpicsSignalRO, "S:FillNumber")
orbit_correction = Component(EpicsSignalRO, "S:OrbitCorrection:CC")
global_feedback = Component(EpicsSignalRO, "SRFB:GBL:LoopStatusBI", string=True)
global_feedback_h = Component(EpicsSignalRO, "SRFB:GBL:HLoopStatusBI", string=True)
global_feedback_v = Component(EpicsSignalRO, "SRFB:GBL:VLoopStatusBI", string=True)

# global_feedback = Component(EpicsSignalRO, "SRFB:GBL:LoopStatusBI", string=True) # Not Found
# global_feedback_h = Component(EpicsSignalRO, "SRFB:GBL:HLoopStatusBI", string=True) # Not Found
# global_feedback_v = Component(EpicsSignalRO, "SRFB:GBL:VLoopStatusBI", string=True) # Not Found

operator_messages = Component(ApsOperatorMessagesDevice)

@property
Expand Down