Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to be consistent with Qt's get/set pattern. #95

Open
rodolakis opened this issue Feb 28, 2024 · 2 comments
Open

Refactor code to be consistent with Qt's get/set pattern. #95

rodolakis opened this issue Feb 28, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rodolakis
Copy link
Collaborator

rodolakis commented Feb 28, 2024

I use the logic of internal attribute / external method, have the get methods implemented, but skipped the set method rule.

@rodolakis rodolakis added the enhancement New feature or request label Feb 28, 2024
@rodolakis rodolakis added this to the v1.1 milestone Feb 28, 2024
@rodolakis rodolakis self-assigned this Feb 28, 2024
@prjemian
Copy link
Collaborator

prjemian commented Feb 28, 2024 via email

@rodolakis
Copy link
Collaborator Author

In mda_folder.py:

def updateSelectionField(self, new_selection):
        self._selection_field = new_selection

is effectively playing the role of what should be self.setSelectionField()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Upgrades
Development

No branches or pull requests

2 participants