Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MariaDB support #64

Merged
merged 3 commits into from
Dec 4, 2020
Merged

MariaDB support #64

merged 3 commits into from
Dec 4, 2020

Conversation

Sybrand
Copy link
Member

@Sybrand Sybrand commented Nov 21, 2020

Added MariaDB support

  • Added MariaDB plugin and Dockerfile.
  • Added MariaDB to documentation.
  • Fixed typos in backup-deploy.json.

This plugin should also work with rhl mysql image, but is untested.

- Added MariaDB to documentation.
- Fixed typos in backup-deploy.json.
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had an initial look. Testing required. If you have a MariaDB or MySQL database in your project you could contribute by helping to test the new plugin.

@WadeBarnes WadeBarnes added the help wanted Extra attention is needed label Nov 21, 2020
@esune
Copy link
Member

esune commented Nov 23, 2020

I will take a look and test asap, and report back. We have a MariaDB database, I will setup a test instance to conduct tests safely.

@esune
Copy link
Member

esune commented Nov 23, 2020

Tested by creating a backup and restoring it on MariaDB: everything works great. I would expect mysql to be the same since they run basically the same engine, right?

Thanks @Sybrand for the plugin :)

@Sybrand
Copy link
Member Author

Sybrand commented Nov 23, 2020

@esune the plugin should work with mysql, yes. One may have to use a different source image for the dockerfile - I used registry.access.redhat.com/rhscl/mariadb-102-rhel7 (depreceted b.t.w!) because it matches what we're using for our mariadb.

@Sybrand Sybrand marked this pull request as ready for review November 23, 2020 22:12
@WadeBarnes
Copy link
Member

WadeBarnes commented Nov 24, 2020

@Sybrand, Can you try using a newer base image. If it's anything like PostgreSQL as long as the backup container is running a version that is the same or newer than the database you're backing up or restoring things work just fine. For example the current version of the Postges backup container uses Postrgres 12, and it can backup and restore Postgres 9.5 databases.

@esune
Copy link
Member

esune commented Nov 24, 2020

Can you try using a newer base image
@WadeBarnes Is it worth using images from https://registry.fedoraproject.org so that we can be on more recent versions than the ones in the Red Hat Developer Portal?

@esune
Copy link
Member

esune commented Nov 24, 2020

Alternatively: registry.access.redhat.com/rhscl/mariadb-102-rhel7. I am not sure whether these images can be pulled from outside OCP, so that was where my question about using the Fedora-based images was going, in addition to those being usually updated sooner.

@WadeBarnes
Copy link
Member

I'm fine with Fedora images. As long as it works, it does not really make much difference.

@Sybrand
Copy link
Member Author

Sybrand commented Nov 24, 2020

@WadeBarnes the most recent version I see on redhat is mariadb-103-rhel7 ( https://catalog.redhat.com/software/containers/rhscl/mariadb-103-rhel7/5c9927a3bed8bd28d0e931d0) - but when I tried to use that, I couldn't - some credential error.
@esune I'm not seeing any straight up MariaDB image on https://registry.fedoraproject.org .
I have no issue upping the version - but I don't have a clue where to go for an appropriate image.

@esune
Copy link
Member

esune commented Nov 24, 2020

@esune I'm not seeing any straight up MariaDB image on https://registry.fedoraproject.org .
I have no issue upping the version - but I don't have a clue where to go for an appropriate image.

Their website is not great, this is the latest one that I can see: registry.fedoraproject.org/f31/mariadb - would have to look up what version that corresponds to.

The issue about being able to pull is what I was referring to above, unless you're on a machine with a rhscl license it will nt let you pull the image.

@Sybrand
Copy link
Member Author

Sybrand commented Nov 24, 2020

@esune I'm not seeing any straight up MariaDB image on https://registry.fedoraproject.org .
I have no issue upping the version - but I don't have a clue where to go for an appropriate image.

Their website is not great, this is the latest one that I can see: registry.fedoraproject.org/f31/mariadb - would have to look up what version that corresponds to.

The issue about being able to pull is what I was referring to above, unless you're on a machine with a rhscl license it will nt let you pull the image.

Cool - got it https://registry.fedoraproject.org/repo/f31/mariadb/tags/ - looks to be 10.3

@@ -0,0 +1,41 @@
from registry.fedoraproject.org/f31/mariadb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@esune I've changed it to fedora - tested backup and verification, works for me.

Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I am happy with the Fedora images - will let @WadeBarnes confirm this works for him as well.

@WadeBarnes
Copy link
Member

Thanks @Sybrand, I'll have a look tomorrow.

@WadeBarnes WadeBarnes merged commit 40100a7 into BCDevOps:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants