-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MariaDB support #64
MariaDB support #64
Conversation
- Added MariaDB to documentation. - Fixed typos in backup-deploy.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had an initial look. Testing required. If you have a MariaDB or MySQL database in your project you could contribute by helping to test the new plugin.
I will take a look and test asap, and report back. We have a MariaDB database, I will setup a test instance to conduct tests safely. |
Tested by creating a backup and restoring it on MariaDB: everything works great. I would expect Thanks @Sybrand for the plugin :) |
@esune the plugin should work with mysql, yes. One may have to use a different source image for the dockerfile - I used registry.access.redhat.com/rhscl/mariadb-102-rhel7 (depreceted b.t.w!) because it matches what we're using for our mariadb. |
@Sybrand, Can you try using a newer base image. If it's anything like PostgreSQL as long as the backup container is running a version that is the same or newer than the database you're backing up or restoring things work just fine. For example the current version of the Postges backup container uses Postrgres 12, and it can backup and restore Postgres 9.5 databases. |
|
Alternatively: |
I'm fine with Fedora images. As long as it works, it does not really make much difference. |
@WadeBarnes the most recent version I see on redhat is mariadb-103-rhel7 ( https://catalog.redhat.com/software/containers/rhscl/mariadb-103-rhel7/5c9927a3bed8bd28d0e931d0) - but when I tried to use that, I couldn't - some credential error. |
Their website is not great, this is the latest one that I can see: registry.fedoraproject.org/f31/mariadb - would have to look up what version that corresponds to. The issue about being able to pull is what I was referring to above, unless you're on a machine with a |
Cool - got it https://registry.fedoraproject.org/repo/f31/mariadb/tags/ - looks to be 10.3 |
@@ -0,0 +1,41 @@ | |||
from registry.fedoraproject.org/f31/mariadb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@esune I've changed it to fedora - tested backup and verification, works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I am happy with the Fedora images - will let @WadeBarnes confirm this works for him as well.
Thanks @Sybrand, I'll have a look tomorrow. |
Added MariaDB support
This plugin should also work with rhl mysql image, but is untested.