Merge branch '1.1.x' into 1.2.x

BCG-X-Official · Nov 9, 2021 · 75ebc96 · 75ebc96
2 parents 6a9eb76 + 2630317
commit 75ebc96
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/RELEASE_NOTES.rst b/RELEASE_NOTES.rst
@@ -34,6 +34,15 @@ FACET 1.1
 FACET 1.1 refines and enhances the association/synergy/redundancy calculations provided
 by the :class:`.LearnerInspector`.
 
+1.1.2
+~~~~~
+
+- DOC: use downloadable dataset in the `getting started` notebook
+- FIX: import :mod:`catboost` if present, else create a local module mockup
+- FIX: correctly identify if ``sample_weights`` is undefined when re-fitting a model
+  on the full dataset in a :class:`.LearnerCrossfit`
+
+
 1.1.1
 ~~~~~
 

diff --git a/src/facet/crossfit/_crossfit.py b/src/facet/crossfit/_crossfit.py
@@ -579,7 +579,7 @@ def run(self) -> FitResult:
         parameters = self.parameters
         pipeline = parameters.pipeline
 
-        if parameters.train_target is None:
+        if parameters.train_weight is None:
             pipeline.fit(
                 X=parameters.train_features,
                 y=parameters.train_target,