Harmonize naming of properties and attributes that reference column names (rather than the actual data) #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@j-ittner these changes look sensible to me and I like that it spans features, target and the weight variable as well. Certainly makes things clear and consistent which I think users will appreciate.
mgelsm
previously approved these changes
Oct 13, 2020
j-ittner
added
refactor
# Conflicts: # src/facet/__init__.py
mgelsm
previously approved these changes
Oct 15, 2020
mgelsm
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Priort to merging this PR, merge BCG-X-Official/sklearndf#46, or the tests for this PR will fail.