Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update synergy/redundancy simulations tutorial #111

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Update synergy/redundancy simulations tutorial #111

merged 4 commits into from
Oct 27, 2020

Conversation

mgelsm
Copy link
Contributor

@mgelsm mgelsm commented Oct 16, 2020

This PR

  • Updates the tutorial providing insights on synergy and redundancy via simulations
    • Rename interaction to combined effect in order to avoid mis-interpretations
    • Updates the building of cv dataframe for simulation 2, to use latest version of ranker.summary_report()
  • Fixes simulation mis-use of a classifier instead of the crossfit object

@mgelsm mgelsm requested a review from jason-bentley October 16, 2020 12:25
@mgelsm mgelsm added the documentation Improvements or additions to documentation label Oct 16, 2020
@mgelsm mgelsm self-assigned this Oct 16, 2020
@mgelsm mgelsm requested a review from j-ittner October 16, 2020 12:26
j-ittner
j-ittner previously requested changes Oct 18, 2020
View reviewed changes
Copy link
Member

@j-ittner j-ittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss!

sphinx/source/tutorial/Classification_simulation_example_Facet.ipynb Outdated Show resolved Hide resolved
sphinx/source/tutorial/Classification_simulation_example_Facet.ipynb Outdated Show resolved Hide resolved
sphinx/source/tutorial/Classification_simulation_example_Facet.ipynb Outdated Show resolved Hide resolved
@mgelsm mgelsm requested a review from j-ittner October 22, 2020 16:38
jason-bentley
jason-bentley approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@jason-bentley jason-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the great work!

@jason-bentley jason-bentley dismissed j-ittner’s stale review October 27, 2020 10:21

Changes have been addressed

@jason-bentley jason-bentley merged commit c7ce6a4 into develop Oct 27, 2020
@j-ittner j-ittner deleted the doc/quality_assurance branch October 27, 2020 13:27
@sithankanna sithankanna restored the doc/quality_assurance branch November 2, 2020 20:19
@j-ittner j-ittner deleted the doc/quality_assurance branch November 13, 2020 17:37
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-bentley jason-bentley jason-bentley approved these changes

@j-ittner j-ittner Awaiting requested review from j-ittner

Assignees

@mgelsm mgelsm

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mgelsm @jason-bentley @j-ittner