Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the overview section in facet's README.rst; plus minor fixes and enhancements #142

Merged
merged 15 commits into from
Nov 4, 2020
Merged

Update the overview section in facet's README.rst; plus minor fixes and enhancements #142

merged 15 commits into from
Nov 4, 2020

Conversation

j-ittner
Copy link
Member

@j-ittner j-ittner commented Nov 3, 2020

This PR updates the README.rst file:

  • updates the summary description of facet
  • consistently uses `facet` to refer to facet
  • makes some additional minor edits and enhancements

@j-ittner j-ittner added the documentation Improvements or additions to documentation label Nov 3, 2020
@j-ittner j-ittner self-assigned this Nov 3, 2020
sithankanna
sithankanna reviewed Nov 3, 2020
View reviewed changes
README.rst Outdated Show resolved Hide resolved
sithankanna
sithankanna reviewed Nov 3, 2020
View reviewed changes
README.rst Outdated Show resolved Hide resolved
jason-bentley
jason-bentley approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@jason-bentley jason-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes look good and the revised text for the descriptions is great.

@j-ittner j-ittner merged commit 10f1d35 into develop Nov 4, 2020
@j-ittner j-ittner deleted the doc/facet_readme_overview_section branch November 4, 2020 14:05
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sithankanna sithankanna sithankanna left review comments

@jason-bentley jason-bentley jason-bentley approved these changes

Assignees

@j-ittner j-ittner

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@j-ittner @jason-bentley @sithankanna