Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to development guidelines #176

Merged
merged 4 commits into from
Dec 5, 2020
Merged

Conversation

jason-bentley
Copy link
Contributor

This PR updates the development guidelines to align with the latest documentation, package build and CI/CD process.

@jason-bentley jason-bentley added the documentation Improvements or additions to documentation label Dec 4, 2020
@jason-bentley jason-bentley self-assigned this Dec 4, 2020
rkdy
rkdy previously approved these changes Dec 4, 2020
Copy link
Collaborator

@rkdy rkdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor adjustments from me.

joerg-schneider
joerg-schneider previously approved these changes Dec 4, 2020
@j-ittner j-ittner dismissed stale reviews from joerg-schneider and rkdy via e3fe093 December 4, 2020 21:23
Copy link
Member

@j-ittner j-ittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Fixed indentation issues and and fixed code block language declarations.

In order to locally install the package for testing, you can run:
conda build metadata, build settings and package dependencies
are obtained from ``meta.yml``. To build and then publish the package to conda,
use the following commands:

.. code-block:: RST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. code-block: sh

@@ -8,7 +8,7 @@ Setup

Python environment
~~~~~~~~~~~~~~~~~~~~~~
There is a ``environment.yml`` provided in the repository root, which installs all
There is an ``environment.yml`` provided in the repository root, which installs all
required development dependencies in the ``facet-develop`` environment.

.. code-block:: RST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. code-block: sh

and delete the package using
PyPI project metadata, build settings and package dependencies
are obtained from ``pyproject.toml``. To build and then publish the package to PyPI,
use the following commands:

.. code-block:: RST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. code-block: sh


**TODO** - once published.
.. code-block:: RST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. code-block: sh

@jason-bentley jason-bentley merged commit e14dd97 into develop Dec 5, 2020
@j-ittner j-ittner deleted the docs/update_release_guide branch December 8, 2020 11:56
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants