-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to development guidelines #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some minor adjustments from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Fixed indentation issues and and fixed code block language declarations.
sphinx/source/contribution_guide.rst
Outdated
In order to locally install the package for testing, you can run: | ||
conda build metadata, build settings and package dependencies | ||
are obtained from ``meta.yml``. To build and then publish the package to conda, | ||
use the following commands: | ||
|
||
.. code-block:: RST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. code-block: sh
sphinx/source/contribution_guide.rst
Outdated
@@ -8,7 +8,7 @@ Setup | |||
|
|||
Python environment | |||
~~~~~~~~~~~~~~~~~~~~~~ | |||
There is a ``environment.yml`` provided in the repository root, which installs all | |||
There is an ``environment.yml`` provided in the repository root, which installs all | |||
required development dependencies in the ``facet-develop`` environment. | |||
|
|||
.. code-block:: RST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. code-block: sh
sphinx/source/contribution_guide.rst
Outdated
and delete the package using | ||
PyPI project metadata, build settings and package dependencies | ||
are obtained from ``pyproject.toml``. To build and then publish the package to PyPI, | ||
use the following commands: | ||
|
||
.. code-block:: RST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. code-block: sh
sphinx/source/contribution_guide.rst
Outdated
|
||
**TODO** - once published. | ||
.. code-block:: RST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. code-block: sh
This PR updates the development guidelines to align with the latest documentation, package build and CI/CD process.