Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickstart and notebook refresh #179

Merged
merged 24 commits into from
Jan 8, 2021
Merged

Conversation

jason-bentley
Copy link
Contributor

This PR refreshes the quickstart and all tutorial notebooks to accommodate changes in the default for the symmetrical argument for synergy and redundancy, as well as a change in ordering of features.

@jason-bentley jason-bentley added the documentation Improvements or additions to documentation label Dec 8, 2020
@jason-bentley jason-bentley self-assigned this Dec 8, 2020
Copy link
Member

@j-ittner j-ittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great overall.

Could you please do a final pass and check if we've missed any opportunity to use asymmetrical S/R matrices?

Thanks!

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@jason-bentley jason-bentley marked this pull request as draft December 14, 2020 13:47
@jason-bentley jason-bentley marked this pull request as ready for review December 18, 2020 12:18
Copy link
Member

@j-ittner j-ittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great explanations of synergy/redundancy - just a minor change request for synergy (I commented this only once, but of course it is relevant for all other occurrences of the explanation) Thanks!

README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
@jason-bentley jason-bentley requested a review from j-ittner January 8, 2021 16:41
@jason-bentley jason-bentley merged commit 9d65b16 into develop Jan 8, 2021
@jason-bentley jason-bentley deleted the docs/notebook_refresh branch January 8, 2021 19:44
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants